src/ia32/lithium-codegen-ia32.cc - Issue 6694044: Strict mode poison pills for function.caller and function.arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6694044: Strict mode poison pills for function.caller and function.arguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Final touches. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 2446c576ce28775951d96371ef297bf69be7ca6f..3ac9ff53a04b570c0682a36a640288f221331c08 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3693,7 +3693,8 @@ void LCodeGen::DoFunctionLiteral(LFunctionLiteral* instr) {

// space for nested functions that don't need literals cloning.

Handle<SharedFunctionInfo> shared_info = instr->shared_info();

bool pretenure = instr->hydrogen()->pretenure();

- if (shared_info->num_literals() == 0 && !pretenure) {

+ if (!pretenure && shared_info->num_literals() == 0 &&

+ !shared_info->strict_mode()) {

FastNewClosureStub stub;

__ push(Immediate(shared_info));

CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr, false);

« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/messages.js » ('j') | no next file with comments »