src/ia32/codegen-ia32.cc - Issue 6694044: Strict mode poison pills for function.caller and function.arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 6694044: Strict mode poison pills for function.caller and function.arguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Final touches. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc

index f1d4cac19178272dac1b5760f6b1a8cc20d66ace..03ca2750bd6b2090a59fac467bc217782a2f97b4 100644

--- a/src/ia32/codegen-ia32.cc

+++ b/src/ia32/codegen-ia32.cc

@@ -4916,9 +4916,10 @@ Result CodeGenerator::InstantiateFunction(

// Use the fast case closure allocation code that allocates in new

// space for nested functions that don't need literals cloning.

- if (scope()->is_function_scope() &&

+ if (!pretenure &&

+ scope()->is_function_scope() &&

function_info->num_literals() == 0 &&

- !pretenure) {

+ !function_info->strict_mode()) { // Strict mode functions use slow path.

FastNewClosureStub stub;

frame()->EmitPush(Immediate(function_info));

return frame()->CallStub(&stub, 1);

« no previous file with comments | « src/handles.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »