Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 6694011: Run PPB_CharSet_Dev logic directly in the plugin process. (Closed)

Created:
9 years, 9 months ago by yzshen1
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Run PPB_CharSet_Dev logic directly in the plugin process. - Move part of the character set conversion logic into ppapi/shared_impl/char_set_impl.{h,cc}. - Change ppb_char_set_proxy to use it directly in the plugin process. - Another minor change is to avoid using malloc/free during character set conversion, and use PPB_Core.MemAlloc/MemFree instead. BUG=none TEST=Pass test_char_set.{h,cc} Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -245 lines) Patch
M ppapi/ppapi_shared_proxy.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 1 chunk +0 lines, -14 lines 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.h View 2 chunks +0 lines, -20 lines 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.cc View 5 chunks +16 lines, -96 lines 0 comments Download
A ppapi/shared_impl/char_set_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ppapi/shared_impl/char_set_impl.cc View 1 chunk +153 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_char_set_impl.cc View 4 chunks +8 lines, -115 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yzshen1
Hi, Brett. Please review. Thanks!
9 years, 9 months ago (2011-03-15 16:42:33 UTC) #1
brettw
9 years, 9 months ago (2011-03-15 16:57:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698