Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/test/webdriver/webdriver_key_converter.h

Issue 6694007: Small test and ChromeDriver fixes to enable additional tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address Dennis' comments Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/session.cc ('k') | chrome/test/webdriver/webdriver_key_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_key_converter.h
diff --git a/chrome/test/webdriver/webdriver_key_converter.h b/chrome/test/webdriver/webdriver_key_converter.h
index e0fad8721f45b3e9eb3de37aeb53c5825893b7c8..1567cdd5cd8e676e11792cc3c7ee16fd4a9728dc 100644
--- a/chrome/test/webdriver/webdriver_key_converter.h
+++ b/chrome/test/webdriver/webdriver_key_converter.h
@@ -22,9 +22,12 @@ WebKeyEvent CreateCharEvent(const std::string& unmodified_text,
const std::string& modified_text,
int modifiers);
-// Converts keys into appropriate |WebKeyEvent|s.
-void ConvertKeysToWebKeyEvents(const string16& keys,
- std::vector<WebKeyEvent>* key_events);
+// Converts keys into appropriate |WebKeyEvent|s. This will do a best effort
+// conversion. However, if the input is invalid it will return false and set
+// an error message.
+bool ConvertKeysToWebKeyEvents(const string16& keys,
+ std::vector<WebKeyEvent>* key_events,
+ std::string* error_msg);
} // namespace webdriver
« no previous file with comments | « chrome/test/webdriver/session.cc ('k') | chrome/test/webdriver/webdriver_key_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698