Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 6693098: -[CollectedCookiesWindowController tabView:didSelectTabViewItem:] declaration (Closed)

Created:
9 years, 8 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

r78692 implemented -[CollectedCookiesWindowController tabView:didSelectTabViewItem:] without declaring that this selector was implemented by adding it to an @interface, adopting a @protocol or inheriting from another @interface that declares it. -tabView:didSelectTabViewItem: is an NSTabViewDelegate @protocol selector. Declare CollectedCookiesWindowController as adopting this @protocol. BUG=none TEST=10.6 SDK build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
9 years, 8 months ago (2011-04-05 16:54:37 UTC) #1
Bernhard Bauer
LGTM, thanks for catching this. Should we add |#pragma mark|s for the different protocol implementations ...
9 years, 8 months ago (2011-04-05 16:57:11 UTC) #2
Mark Mentovai
9 years, 8 months ago (2011-04-05 16:58:27 UTC) #3
bauerb@chromium.org wrote:
> LGTM, thanks for catching this.
>
> Should we add |#pragma mark|s for the different protocol implementations in
> the .mm file?

Nah, I don’t consider that important.

Powered by Google App Engine
This is Rietveld 408576698