Issue 6693098: -[CollectedCookiesWindowController tabView:didSelectTabViewItem:] declaration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6693098: -[CollectedCookiesWindowController tabView:didSelectTabViewItem:] declaration (Closed)

Created:
9 years, 8 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

r78692 implemented -[CollectedCookiesWindowController tabView:didSelectTabViewItem:] without declaring that this selector was implemented by adding it to an @interface, adopting a @protocol or inheriting from another @interface that declares it. -tabView:didSelectTabViewItem: is an NSTabViewDelegate @protocol selector. Declare CollectedCookiesWindowController as adopting this @protocol. BUG=none TEST=10.6 SDK build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80482

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM, thanks for catching this. Should we add |#pragma mark|s for the different protocol implementations ...

9 years, 8 months ago (2011-04-05 16:57:11 UTC) #2

Mark Mentovai

9 years, 8 months ago (2011-04-05 16:58:27 UTC) #3

bauerb@chromium.org wrote:
> LGTM, thanks for catching this.
>
> Should we add |#pragma mark|s for the different protocol implementations in
> the .mm file?

Nah, I don’t consider that important.

Expand Messages | Collapse Messages