Read and Write SSL3, TLS1 and Cert revocation SSL preferences

net/base/ssl_config_service.cc

Index: net/base/ssl_config_service.cc
===================================================================
--- net/base/ssl_config_service.cc	(revision 80372)
+++ net/base/ssl_config_service.cc	(working copy)
@@ -1,18 +1,11 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/ssl_config_service.h"
+#include "net/base/ssl_config_service_defaults.h"

[wtc, 2011/04/05 18:40:37]

Nit: please add a blank line after line 5 because
"net/base/ssl_config_service.h" is the primary header for
this class.  This is the style used in the example in the
Style Guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

[ramant (doing other things), 2011/04/05 21:01:36]

Done.

 #include "net/base/ssl_false_start_blacklist.h"
 
-#if defined(OS_WIN)
-#include "net/base/ssl_config_service_win.h"
-#elif defined(OS_MACOSX)
-#include "net/base/ssl_config_service_mac.h"
-#else
-#include "net/base/ssl_config_service_defaults.h"
-#endif
-
 namespace net {
 
 SSLConfig::CertAndStatus::CertAndStatus() : cert_status(0) {}
@@ -44,13 +37,7 @@
 
 // static
 SSLConfigService* SSLConfigService::CreateSystemSSLConfigService() {
-#if defined(OS_WIN)
-  return new SSLConfigServiceWin;
-#elif defined(OS_MACOSX)
-  return new SSLConfigServiceMac;
-#else
   return new SSLConfigServiceDefaults;

[wtc, 2011/04/05 18:40:37]

Please add a comment to note that we don't use the system SSL
configuration any more.

This means we should be able to get rid of the
CreateSystemSSLConfigService method and simplify the code
further.  You don't need to do this cleanup in this CL.

[ramant (doing other things), 2011/04/05 21:01:36]

Done.

-#endif
 }
 
 // static