Read and Write SSL3, TLS1 and Cert revocation SSL preferences

chrome/browser/ui/options/options_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/options/options_util.h"
 
 #include "base/threading/thread_restrictions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/download/download_manager.h"
@@ skipping 20 matching lines @@
     prefs::kCookieBehavior,
     prefs::kDefaultCharset,
     prefs::kDefaultZoomLevel,
     prefs::kDeleteBrowsingHistory,
     prefs::kDeleteCache,
     prefs::kDeleteCookies,
     prefs::kDeleteDownloadHistory,
     prefs::kDeleteFormData,
     prefs::kDeletePasswords,
     prefs::kDnsPrefetchingEnabled,
-#if defined(OS_LINUX) || defined(OS_FREEBSD) || defined(OS_OPENBSD)

[wtc, 2011/04/05 18:40:37]

IMPORTANT: should we keep this ifdef, since Mac and Windows
never had these preferences in user_prefs?

If we keep this ifdef, please add a comment to explain why
these prefs don't exist on Mac and Windows (i.e., historically
they were stored in system settings).

[ramant (doing other things), 2011/04/05 21:01:36]

Hi Wan-Teh,
  We access these preferences in user_pref (or we do user_prefs->HasPrefPath)
during migration (though migration doesn't have any impact). Added a comment to
delete this code when we delete the migration code.

     prefs::kCertRevocationCheckingEnabled,
     prefs::kSSL3Enabled,
     prefs::kTLS1Enabled,
-#endif
 #if defined(OS_CHROMEOS)
     prefs::kTapToClickEnabled,
     prefs::kTouchpadSensitivity,
 #endif
     prefs::kDownloadDefaultDirectory,
     prefs::kDownloadExtensionsToOpen,
     prefs::kSavingBrowserHistoryDisabled,
     prefs::kEnableSpellCheck,
     prefs::kEnableTranslate,
     prefs::kAutofillEnabled,
@@ skipping 33 matching lines @@
   PrefService* local_state = g_browser_process->local_state();
   // Note that we don't reset the kMetricsReportingEnabled preference here
   // because the reset will reset it to the default setting specified in Chrome
   // source, not the default setting selected by the user on the web page where
   // they downloaded Chrome. This means that if the user ever resets their
   // settings they'll either inadvertedly enable this logging or disable it.
   // One is undesirable for them, one is undesirable for us. For now, we just
   // don't reset it.
   const char* kLocalStatePrefs[] = {
     prefs::kApplicationLocale,
-#if defined(OS_LINUX) || defined(OS_FREEBSD) || defined(OS_OPENBSD)
     prefs::kCertRevocationCheckingEnabled,
     prefs::kSSL3Enabled,
     prefs::kTLS1Enabled,
-#endif
   };
   for (size_t i = 0; i < arraysize(kLocalStatePrefs); ++i)
     local_state->ClearPref(kLocalStatePrefs[i]);
 }
 
 // static
 bool OptionsUtil::ResolveMetricsReportingEnabled(bool enabled) {
   // GoogleUpdateSettings touches the disk from the UI thread. MetricsService
   // also calls GoogleUpdateSettings below. http://crbug/62626
   base::ThreadRestrictions::ScopedAllowIO allow_io;
@@ skipping 14 matching lines @@
   if (metrics) {
     metrics->SetUserPermitsUpload(enabled);
     if (enabled)
       metrics->Start();
     else
       metrics->Stop();
   }
 
   return enabled;
 }