Issue 6693075: Fix up leak in FilePathWatcherTest and UserStyleSheetTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6693075: Fix up leak in FilePathWatcherTest and UserStyleSheetTest (Closed)

Created:
9 years, 8 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
brettw, jam

CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix up leak in FilePathWatcherTest and UserStyleSheetTest BUG=76644, 77042 TEST=Build under valgrind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80490

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -21 lines)			Patch
M	chrome/browser/user_style_sheet_watcher_unittest.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	content/common/file_path_watcher/file_path_watcher_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

dmac

Mind taking a look guys? BTW should mattias and I mark ourselves down in an ...

9 years, 8 months ago (2011-04-04 20:21:28 UTC) #1

jam

9 years, 8 months ago (2011-04-05 17:52:26 UTC) #2

lgtm

the more owners files the better, so yes please add it, thanks