Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 6693059: dev-libs/libp11 import from Gentoo main tree. (Closed)

Created:
9 years, 8 months ago by Flameeyes-Gentoo
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

dev-libs/libp11 import from Gentoo main tree. This version has the libtool dependency fixed. R=petkov BUG=none TEST=./build_packages on {x86,arm}-generic and check on version built. Change-Id: I0d90089dc75d91b327558ace89e16cdbc61ddea5 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bf0cb18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
A dev-libs/libp11/libp11-0.2.7.ebuild View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Flameeyes-Gentoo
9 years, 8 months ago (2011-04-03 23:46:58 UTC) #1
petkov
LGTM Why is usptream updated without upreving?
9 years, 8 months ago (2011-04-04 17:20:20 UTC) #2
Flameeyes-Gentoo
Upstream it is not important for the package to be revbumped because it's a non-build ...
9 years, 8 months ago (2011-04-04 17:45:57 UTC) #3
petkov
9 years, 8 months ago (2011-04-04 17:58:56 UTC) #4
On 2011/04/04 17:45:57, Flameeyes-Gentoo wrote:
> Upstream it is not important for the package to be revbumped because it's a
> non-build change, and libtool is part of our system profiles so it's
> low-importance to force a rebuild for binary packages.

I see. That's OK -- it works better with the Chrome OS build upgrade anyway
because the version number is different.

LGTM

Powered by Google App Engine
This is Rietveld 408576698