Chromium Code Reviews Chromium Code Reviews
Issue 6693054:
Get rid of extensions dependency from content\browser. (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/| Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc |
| =================================================================== |
| --- chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (revision 80243) |
| +++ chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (working copy) |
| @@ -11,6 +11,7 @@ |
| #include "chrome/browser/custom_handlers/protocol_handler_registry.h" |
| #include "chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h" |
| #include "chrome/browser/debugger/devtools_handler.h" |
| +#include "chrome/browser/extensions/extension_tab_helper.h" |
| #include "chrome/browser/file_select_helper.h" |
| #include "chrome/browser/history/top_sites.h" |
| #include "chrome/browser/password_manager/password_manager.h" |
| @@ -54,6 +55,7 @@ |
| autocomplete_history_manager_.reset(new AutocompleteHistoryManager(contents)); |
| autofill_manager_.reset(new AutofillManager(contents)); |
| dev_tools_tab_helper_.reset(new DevToolsTabHelper(contents)); |
| + extension_tab_helper_.reset(new ExtensionTabHelper(contents)); |
| find_tab_helper_.reset(new FindTabHelper(contents)); |
| password_manager_delegate_.reset(new PasswordManagerDelegateImpl(contents)); |
| password_manager_.reset( |
| @@ -186,6 +188,11 @@ |
| TabContentsWrapper* TabContentsWrapper::Clone() { |
| TabContents* new_contents = tab_contents()->Clone(); |
| TabContentsWrapper* new_wrapper = new TabContentsWrapper(new_contents); |
| + |
| + new_wrapper->extension_tab_helper()->SetExtensionApp( |
| + extension_tab_helper_->extension_app()); |
| + new_wrapper->extension_tab_helper()->SetExtensionAppIcon( |
| + extension_tab_helper_->extension_app_icon()); |
|
Avi (use Gerrit)
2011/04/04 02:55:28
Would be nice if you could have a helper function
jam
2011/04/04 05:56:35
Done. Since the ETH has already been created, I u
|
| return new_wrapper; |
| } |
