Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 6693054: Get rid of extensions dependency from content\browser. (Closed)

Created:
9 years, 8 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Erik does not do reviews, Aaron Boodman, Paweł Hajdan Jr., Matt Perry
Visibility:
Public.

Description

Get rid of extensions dependency from content\browser. BUG=76789 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80315

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -274 lines) Patch
M chrome/browser/browser_browsertest.cc View 1 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_tab_helper.h View 1 2 3 4 5 6 7 1 chunk +93 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_tab_helper.cc View 1 2 3 4 5 6 7 1 chunk +144 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 5 5 chunks +19 lines, -10 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 3 4 5 3 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_infobar_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_gtk.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/test_tab_contents_wrapper.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/browser_with_test_window_test.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/browser_with_test_window_test.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/content_browser_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/content_browser_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context_unittest.cc View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/plugin_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/site_instance.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/site_instance.cc View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 6 chunks +0 lines, -56 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 10 chunks +2 lines, -102 lines 0 comments Download
M content/browser/webui/web_ui_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/notification_type.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
In the next cl, I will move dispatching of ExtensionHostMsg_Request (and also ExtensionHostMsg_PostMessage and the ...
9 years, 8 months ago (2011-04-03 23:55:15 UTC) #1
Avi (use Gerrit)
LGTM as is. Would have liked to have seen fewer uses of GetCurrentWrapperForContents, but it's ...
9 years, 8 months ago (2011-04-04 02:55:28 UTC) #2
jam
http://codereview.chromium.org/6693054/diff/2113/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right): http://codereview.chromium.org/6693054/diff/2113/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc#newcode195 chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:195: extension_tab_helper_->extension_app_icon()); On 2011/04/04 02:55:28, Avi wrote: > Would be ...
9 years, 8 months ago (2011-04-04 05:56:35 UTC) #3
Avi (use Gerrit)
9 years, 8 months ago (2011-04-04 13:56:22 UTC) #4
Much appreciated. SLGTM

Powered by Google App Engine
This is Rietveld 408576698