Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 6693053: Fix x width mapping when 720x480 mode is forced using -M1 (Closed)

Created:
9 years, 8 months ago by mdhayter
Modified:
9 years, 7 months ago
Reviewers:
tbroch1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix x width mapping when 720x480 mode is forced using -M1 When the ch7036_monitor code is run with the -M1 flag to force 720x480@60 the aspect ratio cannot be computed (because it is non-standard) this causes the width remapping to index -1 in the array and get bogus width data. This is fixed by not remapping when the aspect is negative. BUG=chrome-os-partner:2850 TEST=sudo ch7036_monitor -v -M1 check picture remains when monitor attached Change-Id: Ic0c55bba544b5a890bdeba37a36f85cb28f9c533 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=08e79d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M ch7036_monitor.c View 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mdhayter
Please review fix for -M1 issue
9 years, 8 months ago (2011-04-02 22:18:28 UTC) #1
tbroch1
9 years, 8 months ago (2011-04-02 23:06:38 UTC) #2
LGTM
On 2011/04/02 22:18:28, mdhayter wrote:
> Please review fix for -M1 issue

Powered by Google App Engine
This is Rietveld 408576698