Issue 6693050: memento_softwareupdate: fix split_write error "bad file descriptor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6693050: memento_softwareupdate: fix split_write error "bad file descriptor" (Closed)

Created:
9 years, 8 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
adlr, Che-Liang Chiou

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/memento_softwareupdate.git@master

Visibility:
Public.

Description

memento_softwareupdate: fix split_write error "bad file descriptor" The split_write didn't return file descriptor. Compilers with different code generator and different configuration (optimization/security/...) may cause different results, that's why we didn't catch this until very recently. BUG=chrome-os-partner:3013 TEST=on R12, factory_install.sh runs successfully. Change-Id: Icbc18757ece105035f70598642332191381719c8 R=clchiou@chromium.org,adlr@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=272f291

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	split_write.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages