Remove WebUI menu

Remove WebUI menu

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78450

[oshima, 2011-03-16 19:42:26]

can one of you review this? It's just removal of webui menu.

[Ben Goodger (Google), 2011-03-16 19:46:08]

Rubber stamp LGTM for code removal. Thanks for doing this - this will make the
WM-related views cleanup much easier!

[stevenjb, 2011-03-16 19:47:37]

LGTM

[commit-bot: I haz the power, 2011-03-17 19:03:28]

Can't apply patch for file chrome/browser/ui/views/toolbar_view.cc.
patching file chrome/browser/ui/views/toolbar_view.cc
Hunk #1 FAILED at 40.
Hunk #2 FAILED at 136.
Hunk #3 FAILED at 268.
Hunk #4 FAILED at 327.
Hunk #5 FAILED at 349.
5 out of 5 hunks FAILED -- saving rejects to file
chrome/browser/ui/views/toolbar_view.cc.rej

[M-A Ruel, 2011-03-17 19:04:54]

On 2011/03/17 19:03:28, commit-bot wrote:
> Can't apply patch for file chrome/browser/ui/views/toolbar_view.cc.
> patching file chrome/browser/ui/views/toolbar_view.cc
> Hunk #1 FAILED at 40.
> Hunk #2 FAILED at 136.
> Hunk #3 FAILED at 268.
> Hunk #4 FAILED at 327.
> Hunk #5 FAILED at 349.
> 5 out of 5 hunks FAILED -- saving rejects to file
> chrome/browser/ui/views/toolbar_view.cc.rej

Status for chrome/browser/chromeos/views/menu_locator.cc wasn't set...

[oshima, 2011-03-17 21:35:59]

On Thu, Mar 17, 2011 at 12:04 PM, <maruel@chromium.org> wrote:

> On 2011/03/17 19:03:28, commit-bot wrote:
>
>> Can't apply patch for file chrome/browser/ui/views/toolbar_view.cc.
>> patching file chrome/browser/ui/views/toolbar_view.cc
>> Hunk #1 FAILED at 40.
>> Hunk #2 FAILED at 136.
>> Hunk #3 FAILED at 268.
>> Hunk #4 FAILED at 327.
>> Hunk #5 FAILED at 349.
>> 5 out of 5 hunks FAILED -- saving rejects to file
>> chrome/browser/ui/views/toolbar_view.cc.rej
>>
>
What is this about? I committed this change manually.


>
> Status for chrome/browser/chromeos/views/menu_locator.cc wasn't set...
>
>
Hmm, something wrong seemed happen when updating my patch? How (or if)
should I fix?

- oshima


>
> http://codereview.chromium.org/6693032/
>

[M-A Ruel, 2011-03-18 00:03:21]

Le 17 mars 2011 17:35, oshima <oshima@chromium.org> a écrit :

>
>
> On Thu, Mar 17, 2011 at 12:04 PM, <maruel@chromium.org> wrote:
>
>> On 2011/03/17 19:03:28, commit-bot wrote:
>>
>>> Can't apply patch for file chrome/browser/ui/views/toolbar_view.cc.
>>> patching file chrome/browser/ui/views/toolbar_view.cc
>>> Hunk #1 FAILED at 40.
>>> Hunk #2 FAILED at 136.
>>> Hunk #3 FAILED at 268.
>>> Hunk #4 FAILED at 327.
>>> Hunk #5 FAILED at 349.
>>> 5 out of 5 hunks FAILED -- saving rejects to file
>>> chrome/browser/ui/views/toolbar_view.cc.rej
>>>
>>
> What is this about? I committed this change manually.
>

Yeah the commit queue just didn't see the patch was already committed.

Status for chrome/browser/chromeos/views/menu_locator.cc wasn't set...
>>
>>
> Hmm, something wrong seemed happen when updating my patch? How (or if)
> should I fix?
>

Just gcl upload again when that happens. I've seen higher GAE instability
lately.

M-A


>
>> http://codereview.chromium.org/6693032/
>>
>
>