Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2702)

Unified Diff: chrome/browser/ui/search_engines/template_url_table_model.cc

Issue 6693021: fav icon -> favicon. Pass 5: fav_icon -> favicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/touch/tabs/touch_tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search_engines/template_url_table_model.cc
diff --git a/chrome/browser/ui/search_engines/template_url_table_model.cc b/chrome/browser/ui/search_engines/template_url_table_model.cc
index 6c82c853686938fc972f8d4fdbc9a957f7792089..4cdcda27f69bda05c3b44595c22f849ef6feb120 100644
--- a/chrome/browser/ui/search_engines/template_url_table_model.cc
+++ b/chrome/browser/ui/search_engines/template_url_table_model.cc
@@ -52,8 +52,8 @@ class ModelEntry {
SkBitmap GetIcon() {
if (load_state_ == NOT_LOADED)
LoadFavIcon();
- if (!fav_icon_.isNull())
- return fav_icon_;
+ if (!favicon_.isNull())
+ return favicon_;
return *default_icon;
}
@@ -61,7 +61,7 @@ class ModelEntry {
// fetched again. This should be invoked if the url is modified.
void ResetIcon() {
load_state_ = NOT_LOADED;
- fav_icon_ = SkBitmap();
+ favicon_ = SkBitmap();
}
private:
@@ -79,19 +79,19 @@ class ModelEntry {
Profile::EXPLICIT_ACCESS);
if (!favicon_service)
return;
- GURL fav_icon_url = template_url().GetFavIconURL();
- if (!fav_icon_url.is_valid()) {
+ GURL favicon_url = template_url().GetFavIconURL();
+ if (!favicon_url.is_valid()) {
// The favicon url isn't always set. Guess at one here.
if (template_url_.url() && template_url_.url()->IsValid()) {
GURL url = GURL(template_url_.url()->url());
if (url.is_valid())
- fav_icon_url = TemplateURL::GenerateFaviconURL(url);
+ favicon_url = TemplateURL::GenerateFaviconURL(url);
}
- if (!fav_icon_url.is_valid())
+ if (!favicon_url.is_valid())
return;
}
load_state_ = LOADING;
- favicon_service->GetFavicon(fav_icon_url,
+ favicon_service->GetFavicon(favicon_url,
&request_consumer_,
NewCallback(this, &ModelEntry::OnFavIconDataAvailable));
}
@@ -104,13 +104,13 @@ class ModelEntry {
GURL icon_url) {
load_state_ = LOADED;
if (know_favicon && data.get() &&
- gfx::PNGCodec::Decode(data->front(), data->size(), &fav_icon_)) {
+ gfx::PNGCodec::Decode(data->front(), data->size(), &favicon_)) {
model_->FavIconAvailable(this);
}
}
const TemplateURL& template_url_;
- SkBitmap fav_icon_;
+ SkBitmap favicon_;
LoadState load_state_;
TemplateURLTableModel* model_;
CancelableRequestConsumer request_consumer_;
« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/touch/tabs/touch_tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698