Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 6693010: Use extension to show activation message. (Closed)

Created:
9 years, 9 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
Jay Civelli, zel
CC:
chromium-reviews, jam, arv (Not doing code reviews), darin-cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Use extension to show activation message. Use localString to use WebUI parameter. I don't know exactly how, but seems like the wrong code was checked in and time_to_wait parameter wasn't used property. This CL revert this change to original code that uses LocalStrings. Ignore iframe's navigation message in interstitial page so it doesn't create insterstitial page twice. BUG=chromium-os:12286 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78275

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 1

Patch Set 4 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -81 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/offline_resource_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/resources/activate_broadband_info.png View Binary file 0 comments Download
M chrome/browser/resources/offline_load.html View 1 3 chunks +77 lines, -65 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
Zel, this goes along with chromeos change I sent earlier. Jay, can you review the ...
9 years, 9 months ago (2011-03-15 18:26:37 UTC) #1
zel
http://codereview.chromium.org/6693010/diff/3001/views/controls/menu/menu_host_gtk.cc File views/controls/menu/menu_host_gtk.cc (right): http://codereview.chromium.org/6693010/diff/3001/views/controls/menu/menu_host_gtk.cc#newcode165 views/controls/menu/menu_host_gtk.cc:165: if (pointer_grab_status == GDK_GRAB_NOT_VIEWABLE) { does this file belong ...
9 years, 9 months ago (2011-03-15 18:39:45 UTC) #2
oshima
On Tue, Mar 15, 2011 at 11:39 AM, <zelidrag@chromium.org> wrote: > > > http://codereview.chromium.org/6693010/diff/3001/views/controls/menu/menu_host_gtk.cc > ...
9 years, 9 months ago (2011-03-15 19:30:15 UTC) #3
Jay Civelli
LGTM for the interstitial page change.
9 years, 9 months ago (2011-03-15 20:16:32 UTC) #4
zel
9 years, 9 months ago (2011-03-15 20:25:09 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698