Issue 6693001: Ignore git config errors that may occur in enter_chroot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6693001: Ignore git config errors that may occur in enter_chroot. (Closed)

Created:
9 years, 9 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Ignore git config errors that may occur in enter_chroot. git config doesn't behave well if there are multiple callers calling it at the same time. Since this is best effort anyway, I'm adding an || true so that multithreads calls to this don't fail. I removed my previous work around to this since it wasn't generic enough. Change-Id: I12f2d3faaa745c1ff675a297bb09c567a88aa185 BUG=chromium-os:13070 TEST=Ran it a lot Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9d30ce8

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	bin/au_test_harness/cros_au_test_harness.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	enter_chroot.sh	View		2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages