Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 669270: Remove unneeded variable usage analysis. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove unneeded variable usage analysis. A variable usage analysis pass was run on toplevel and lazily-compiled code but never used. Remove this pass and the data structures it builds. The representation of variable usage for Variables has been changed from a struct containing a (weighted) count of reads and writes to a simple flag. VariableProxies are always used, as before. The unused "object uses" is removed. Committed: http://code.google.com/p/v8/source/detail?r=4052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -610 lines) Patch
M src/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/ast.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scopeinfo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
src/scopes.cc View 5 chunks +11 lines, -12 lines 0 comments Download
D src/usage-analyzer.h View 1 chunk +0 lines, -40 lines 0 comments Download
D src/usage-analyzer.cc View 1 chunk +0 lines, -426 lines 0 comments Download
M src/variables.h View 3 chunks +3 lines, -33 lines 0 comments Download
M src/variables.cc View 2 chunks +1 line, -51 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 9 months ago (2010-03-08 12:16:59 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-08 12:45:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698