Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 669230: Update Power Test to be 60/20/10 test. (Closed)

Created:
10 years, 9 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
petkov, Sameer Nanda
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Update Power Test to be 60/20/10 test. - Focus tabs if the focus parameter is set. - Only scroll tabs that are focused. - Timeout tabs after 5 seconds. - Fix scroll_loop to behave as intended. - Update default params to run for an hour. - Add globally playable music. - Delete unrepresentative sites from test list TEST=none BUG=none

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix issues pointed out by snanda and petkov #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -74 lines) Patch
M client/site_tests/power_LoadTest/extension/background.html View 1 4 chunks +56 lines, -28 lines 0 comments Download
M client/site_tests/power_LoadTest/extension/ct.js View 1 chunk +10 lines, -13 lines 0 comments Download
M client/site_tests/power_LoadTest/extension/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/power_LoadTest/extension/params.js View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/power_LoadTest/extension/urls.js View 1 5 chunks +55 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidjames
10 years, 9 months ago (2010-03-06 02:48:11 UTC) #1
petkov
fly by... http://codereview.chromium.org/669230/diff/1/6 File client/site_tests/power_LoadTest/extension/urls.js (right): http://codereview.chromium.org/669230/diff/1/6#newcode140 client/site_tests/power_LoadTest/extension/urls.js:140: URLS[u_index++] = 'http://www.comacast.net'; comacast.net? or comcast.net?
10 years, 9 months ago (2010-03-06 06:21:00 UTC) #2
Sameer Nanda
LGTM w/ nits http://codereview.chromium.org/669230/diff/1/2 File client/site_tests/power_LoadTest/extension/background.html (right): http://codereview.chromium.org/669230/diff/1/2#newcode45 client/site_tests/power_LoadTest/extension/background.html:45: chrome.tabs.update(cycle.id, {'url': cycle.urls[cycle.idx], 'selected': true}); > ...
10 years, 9 months ago (2010-03-07 03:35:45 UTC) #3
davidjames
10 years, 9 months ago (2010-03-08 17:53:01 UTC) #4
Sameer Nanda
10 years, 9 months ago (2010-03-08 18:03:14 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698