Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Side by Side Diff: src/builtins.cc

Issue 669164: Explicitly release allocated memory as Vector doesn't do that in dtor. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 int n_args = args.length() - 1; 332 int n_args = args.length() - 1;
333 for (int i = 0; i < n_args; i++) { 333 for (int i = 0; i < n_args; i++) {
334 argv[i] = &args[i + 1]; 334 argv[i] = &args[i + 1];
335 } 335 }
336 bool pending_exception = false; 336 bool pending_exception = false;
337 Handle<Object> result = Execution::Call(function, 337 Handle<Object> result = Execution::Call(function,
338 args.receiver(), 338 args.receiver(),
339 n_args, 339 n_args,
340 argv.start(), 340 argv.start(),
341 &pending_exception); 341 &pending_exception);
342 argv.Dispose();
342 if (pending_exception) return Failure::Exception(); 343 if (pending_exception) return Failure::Exception();
343 return *result; 344 return *result;
344 } 345 }
345 346
346 347
347 BUILTIN(ArrayPush) { 348 BUILTIN(ArrayPush) {
348 JSArray* array = JSArray::cast(*args.receiver()); 349 JSArray* array = JSArray::cast(*args.receiver());
349 ASSERT(array->HasFastElements()); 350 ASSERT(array->HasFastElements());
350 351
351 int len = Smi::cast(array->length())->value(); 352 int len = Smi::cast(array->length())->value();
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1350 if (entry->contains(pc)) { 1351 if (entry->contains(pc)) {
1351 return names_[i]; 1352 return names_[i];
1352 } 1353 }
1353 } 1354 }
1354 } 1355 }
1355 return NULL; 1356 return NULL;
1356 } 1357 }
1357 1358
1358 1359
1359 } } // namespace v8::internal 1360 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698