src/runtime.cc - Issue 669159: Fixed filling of char array in StringToArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 669159: Fixed filling of char array in StringToArray. (Closed)

Patch Set: Fix typo Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d0f90818d6460ca04330746ac3ab2c7b519d1943..90bbaf32d66787bacaa45fb494224479249eaeed 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -4233,7 +4233,7 @@ static int CopyCachedAsciiCharsToArray(const char* chars,

}

if (i < length) {

ASSERT(Smi::FromInt(0) == 0);

- memset(elements->data_start() + i, 0, length - i);

+ memset(elements->data_start() + i, 0, kPointerSize * (length - i));

}

#ifdef DEBUG

for (int j = 0; j < length; ++j) {

« no previous file with comments | « no previous file | test/mjsunit/string-split-cache.js » ('j') | no next file with comments »