Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669131: ARM: add arm_fpu option to specify which version of vfp to use (Closed)

Created:
10 years, 9 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

ARM: add arm_fpu option to specify which version of vfp to use Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40699

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
Some archs don't support vfpv3, but a subset (e.g. vfpv3-d16), so give them an option ...
10 years, 9 months ago (2010-03-05 01:06:26 UTC) #1
bradn
LGTM http://codereview.chromium.org/669131/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/669131/diff/1/2#newcode218 build/common.gypi:218: # Set ARM fpu compilation flags (only meaningful ...
10 years, 9 months ago (2010-03-05 01:07:37 UTC) #2
piman
http://codereview.chromium.org/669131/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/669131/diff/1/2#newcode218 build/common.gypi:218: # Set ARM fpu compilation flags (only meaningful if ...
10 years, 9 months ago (2010-03-05 01:51:16 UTC) #3
bradn
10 years, 9 months ago (2010-03-05 02:28:30 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698