Issue 669117: Remove a CHECK() which was firing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669117: Remove a CHECK() which was firing.... (Closed)

Created:
10 years, 9 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, Paul Godavari, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove a CHECK() which was firing. The problem was the load state poller may call OnUploadProgress() while a redirect is in progress. It should be safe to remove the CHECK(), since it was recently added and execution used to pass through previously in this case. BUG=37035 TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40684

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/safe_browsing_resource_handler.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages