This will fix the build issues for sysstat, as we don't need to install.

This will fix the build issues for sysstat, as we don't need to install.

[ericli, 2010-03-04 23:19:10]

There might be an issue when you call mpstat inside netperf2.py.

mpstat = os.path.join(self.autodir + 'deps/sysstat/mpstat')

without make install, mpstat binary will sitinside deps/sysstat/src/mpstat.

You might confirm that as you are testing it for now.


On 2010/03/04 23:10:48, kdlucas wrote:
>

[kdlucas, 2010-03-05 18:21:57]

Yup, I'll account for that in the tests.

[ericli, 2010-03-05 22:20:39]

http://codereview.chromium.org/669113/diff/1004/5
File client/tests/netperf2/netperf2.py (right):

http://codereview.chromium.org/669113/diff/1004/5#newcode43
client/tests/netperf2/netperf2.py:43: dep_dir = os.path.join(self.autodir,
'deps', dep)
This is duplicated with line 28.

[kdlucas, 2010-03-05 23:24:44]

Looks like we need additional steps since setup() may not be executed during the
actual test run.

http://codereview.chromium.org/669113/diff/1004/5
File client/tests/netperf2/netperf2.py (right):

http://codereview.chromium.org/669113/diff/1004/5#newcode43
client/tests/netperf2/netperf2.py:43: dep_dir = os.path.join(self.autodir,
'deps', dep)
So I think what is happening here is after we compile all of the precompiled
binaries, setup() doesn't get run again, and this is the step the calls
job.setup_dep(). Since that doesn't get called any longer, the dependencies are
not getting installed on the client.

On 2010/03/05 22:20:39, ericli wrote:
> This is duplicated with line 28.

[ericli, 2010-03-05 23:28:06]

Got it.

LGTM.

On 2010/03/05 23:24:44, kdlucas wrote:
> Looks like we need additional steps since setup() may not be executed during
the
> actual test run.
> 
> http://codereview.chromium.org/669113/diff/1004/5
> File client/tests/netperf2/netperf2.py (right):
> 
> http://codereview.chromium.org/669113/diff/1004/5#newcode43
> client/tests/netperf2/netperf2.py:43: dep_dir = os.path.join(self.autodir,
> 'deps', dep)
> So I think what is happening here is after we compile all of the precompiled
> binaries, setup() doesn't get run again, and this is the step the calls
> job.setup_dep(). Since that doesn't get called any longer, the dependencies
are
> not getting installed on the client.
> 
> On 2010/03/05 22:20:39, ericli wrote:
> > This is duplicated with line 28.