Issue 6691063: A change in the way User Agent is modified caused Chrome Frame to mistakenly disable itself when ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6691063: A change in the way User Agent is modified caused Chrome Frame to mistakenly disable itself when ... (Closed)

Created:
9 years, 8 months ago by erikwright (departed)

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, ananta

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

A change in the way User Agent is modified caused Chrome Frame to mistakenly disable itself when installing into pre-existing IE processes. BUG=60018 TEST=Open IE when Chrome Frame is not installed. Install Chrome Frame. Instantiate the Chrome Frame ActiveX control and call registerBhoIfNeeded. Visit wordpress.com and verify that ChromeFrame is activated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80497

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -19 lines)			Patch
	M	chrome_frame/bho.cc	View		2 chunks	+2 lines, -19 lines	0 comments	Download
	M	chrome_frame/http_negotiate.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages