Expose WebGL typed array constructors in the shell sample

Expose WebGL typed array constructors in the shell sample

Committed: http://code.google.com/p/v8/source/detail?r=7507

[Jakob Kummerow, 2011-04-05 16:49:26]

Please review.

[Mads Ager (chromium), 2011-04-05 20:45:33]

LGTM

Will be very nice to use this to rewrite the test-api external and pixel array
tests!

http://codereview.chromium.org/6691061/diff/1/samples/shell.cc
File samples/shell.cc (right):

http://codereview.chromium.org/6691061/diff/1/samples/shell.cc#newcode515
samples/shell.cc:515: return CreateExternalArray(args, v8::kExternalPixelArray,
sizeof(uint8_t));
Interesting. The linter does not see this type as a type? I wonder if you need
the above NOLINT comment in that case. Maybe only the float one is actually
recognized by the linter as a type?

[Jakob Kummerow, 2011-04-06 08:08:37]

http://codereview.chromium.org/6691061/diff/1/samples/shell.cc
File samples/shell.cc (right):

http://codereview.chromium.org/6691061/diff/1/samples/shell.cc#newcode515
samples/shell.cc:515: return CreateExternalArray(args, v8::kExternalPixelArray,
sizeof(uint8_t));
On 2011/04/05 20:45:33, Mads Ager wrote:
> Interesting. The linter does not see this type as a type? I wonder if you need
> the above NOLINT comment in that case. Maybe only the float one is actually
> recognized by the linter as a type?

Indeed. I've removed all the //NOLINT tags except for the float case, and
presubmit.py doesn't complain.