Issue 6691034: First pass to transition away for gclient_utils.Error and gclient_utils.CheckedCallError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6691034: First pass to transition away for gclient_utils.Error and gclient_utils.CheckedCallError. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

First pass to transition away for gclient_utils.Error and gclient_utils.CheckedCallError. Make sure every site that catches gclient_utils.Error also catch subprocess2.CalledProcessError. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80339

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -25 lines)			Patch
M	gcl.py	View	5 chunks	+5 lines, -4 lines	0 comments	Download
M	gclient.py	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	gclient_scm.py	View	5 chunks	+6 lines, -5 lines	0 comments	Download
M	scm.py	View	7 chunks	+11 lines, -9 lines	0 comments	Download
M	tests/gcl_unittest.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/scm_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/trychange_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trychange.py	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages