Issue 669101: Fix invalid fast return in splice when returned array is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669101: Fix invalid fast return in splice when returned array is empty. (Closed)

Created:
10 years, 9 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Kasper Lund, Vitaly Repeshko

CC:
v8-dev

Visibility:
Public.

Description

Fix invalid fast return in splice when returned array is empty. TBR=vitalyr@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4027

Patch Set 1 #

Total comments: 5

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -18 lines)			Patch
	M	src/builtins.cc	View		4 chunks	+26 lines, -18 lines	5 comments	Download
	M	test/mjsunit/array-splice.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

10 years, 9 months ago (2010-03-05 07:08:14 UTC) #2

http://codereview.chromium.org/669101/diff/1/2
File src/builtins.cc (right):

http://codereview.chromium.org/669101/diff/1/2#newcode595
src/builtins.cc:595: int relativeStart = 0;
Don't use camelCase for local variables.

http://codereview.chromium.org/669101/diff/1/2#newcode602
src/builtins.cc:602: int actualStart = (relativeStart < 0) ? Max(len +
relativeStart, 0)
Don't use camelCase for local variables.

http://codereview.chromium.org/669101/diff/1/2#newcode609
src/builtins.cc:609: int deleteCount = len;
Don't use camelCase for local variables.

http://codereview.chromium.org/669101/diff/1/2#newcode618
src/builtins.cc:618: int actualDeleteCount = Min(Max(deleteCount, 0), len -
actualStart);
Don't use camelCase for local variables.

http://codereview.chromium.org/669101/diff/1/2#newcode648
src/builtins.cc:648: int itemCount = (n_arguments > 1) ? (n_arguments - 2) : 0;
Don't use camelCase for local variables.

Expand Messages | Collapse Messages