Strict mode poision pills.

test/mjsunit/strict-mode.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 958 matching lines @@
 
   function nonstrict(a, b) {
     a = "c";
     b = "d";
     return [a, b, arguments[0], arguments[1]];
   }
 
   assertEquals(["c", "d", "a", "b"], strict("a", "b"));
   assertEquals(["c", "d", "c", "d"], nonstrict("a", "b"));
 })();
+
+
+(function TestStrictFunctionPills() {
+  function strict() {
+    "use strict";
+  }
+  assertThrows(function() { strict.caller; }, TypeError);
+  assertThrows(function() { strict.arguments; }, TypeError);
+
+  var another = new Function("'use strict'");
+  assertThrows(function() { another.caller; }, TypeError);
+  assertThrows(function() { another.arguments; }, TypeError);
+

[Lasse Reichstein, 2011/03/14 12:20:15]

How about an inherited strictness:
  var athird = (function() { "use strict"; return function(){};})();
or do we consider it well tested that this generates a strict function?

[Martin Maly, 2011/03/14 16:39:26]

Done.

+  function CheckPill(pill) {
+    assertEquals("function", typeof pill);
+    assertInstanceof(pill, Function);
+    assertThrows(function() { pill.property = "value"; }, TypeError);
+    assertThrows(pill, TypeError);

[Lasse Reichstein, 2011/03/14 12:20:15]

Should you check whether it has a .prototype property?

[Martin Maly, 2011/03/14 16:39:26]

Good suggestion. Turns out there was a bug here. After I create the JSFunction
for poison pill I need to set its map to the strict map with prototype. Made
that 1 line change.

+  }
+
+  function CheckPillDescriptor(func, name) {
+    var descriptor = Object.getOwnPropertyDescriptor(func, name);
+    CheckPill(descriptor.get)
+    CheckPill(descriptor.set);
+    assertEquals(false, descriptor.enumerable);
+    assertEquals(false, descriptor.configurable);

[Lasse Reichstein, 2011/03/14 12:20:15]

I think we have an assertFalse function.

[Martin Maly, 2011/03/14 16:39:26]

Done.

+  }
+  CheckPillDescriptor(strict, "caller");
+  CheckPillDescriptor(strict, "arguments");
+  CheckPillDescriptor(another, "caller");
+  CheckPillDescriptor(another, "arguments");
+})();