Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 6691001: Add a message to the screen when depot tools have been updated.... (Closed)

Created:
9 years, 9 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
M-A Ruel, dhollowa
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add a message to the screen when depot tools have been updated. BUG=none TEST=message appears only when new revision changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77997

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M update_depot_tools View 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Mohamed Mansour
Hi Marc-Antoine, The output is just a simple line: $ gclient Depot Tools has been ...
9 years, 9 months ago (2011-03-13 22:35:22 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/6691001/diff/1/update_depot_tools File update_depot_tools (right): http://codereview.chromium.org/6691001/diff/1/update_depot_tools#newcode67 update_depot_tools:67: if [[ "$BEFORE_REVISION" != "$AFTER_REVISION" ]]; then you ...
9 years, 9 months ago (2011-03-14 00:42:48 UTC) #2
dhollowa
9 years, 9 months ago (2011-03-14 04:56:51 UTC) #3
After this CL I'm seeing two extra lines:

$ gclient sync
svn: '.' is not a working copy
svn: '.' is not a working copy

from IRC:

davidben: this should probably fix the svn info thing:
[9:44pm] davidben: -  echo `svn info | awk '{ if ($1 == "Revision:") { print $2
}}'`
[9:44pm] davidben: +  echo `svn info "$base_dir" | awk '{ if ($1 == "Revision:")
{ print $2 }}'`

Powered by Google App Engine
This is Rietveld 408576698