Fix a special case (zero length result array).

Fix a special case (zero length result array).

Committed: http://code.google.com/p/v8/source/detail?r=4026

[Vitaly Repeshko, 2010-03-04 18:36:57]

LGTM.

http://codereview.chromium.org/669075/diff/1/2
File src/builtins.cc (right):

http://codereview.chromium.org/669075/diff/1/2#newcode258
src/builtins.cc:258: result_array->set_length(Smi::FromInt(0));
You could do result_array->SetContent(Heap::empty_fixed_array()) instead of
these two lines if performance is not too important here.

http://codereview.chromium.org/669075/diff/1/4
File test/mjsunit/array-splice.js (right):

http://codereview.chromium.org/669075/diff/1/4#newcode45
test/mjsunit/array-splice.js:45: // Check various variants of empty array's
slicing.
splicing?

[antonm, 2010-03-04 21:25:55]

Thanks, a lot, Vitaly.

http://codereview.chromium.org/669075/diff/1/2
File src/builtins.cc (right):

http://codereview.chromium.org/669075/diff/1/2#newcode258
src/builtins.cc:258: result_array->set_length(Smi::FromInt(0));
On 2010/03/04 18:36:57, Vitaly wrote:
> You could do result_array->SetContent(Heap::empty_fixed_array()) instead of
> these two lines if performance is not too important here.

If you don't mind, I'd rather keep as is---not to make someone else to (falsely)
think it's an easy optimization spot.

http://codereview.chromium.org/669075/diff/1/4
File test/mjsunit/array-splice.js (right):

http://codereview.chromium.org/669075/diff/1/4#newcode45
test/mjsunit/array-splice.js:45: // Check various variants of empty array's
slicing.
On 2010/03/04 18:36:57, Vitaly wrote:
> splicing?

Thanks.  Done.