Issue 669058: Try to fix issue 632 by being more careful in the locking/unlocking...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669058: Try to fix issue 632 by being more careful in the locking/unlocking... (Closed)

Created:
10 years, 9 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Try to fix issue 632 by being more careful in the locking/unlocking in the test-log/ProfMultipleThreads. Committed: http://code.google.com/p/v8/source/detail?r=4021

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	src/api.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	test/cctest/test-log.cc	View		1 chunk	+14 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik Corry

10 years, 9 months ago (2010-03-04 13:22:12 UTC) #3

LGTM but I have no idea why this should affect the bug.