Issue 669051: - Rearrange fields in SharedFunctionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669051: - Rearrange fields in SharedFunctionInfo. (Closed)

Created:
10 years, 9 months ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Rearrange fields in SharedFunctionInfo. Committed: http://code.google.com/p/v8/source/detail?r=4014

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -24 lines)			Patch
	M	src/objects.h	View	1	2 chunks	+17 lines, -19 lines	0 comments	Download
	M	src/objects.cc	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM! http://codereview.chromium.org/669051/diff/1/2 File src/objects.cc (right): http://codereview.chromium.org/669051/diff/1/2#newcode4961 src/objects.cc:4961: IteratePointers(v, kNameOffset, kThisPropertyAssignmentsOffset + kPointerSize); Line 1 char ...

10 years, 9 months ago (2010-03-04 09:47:15 UTC) #2

iposva

10 years, 9 months ago (2010-03-04 09:50:56 UTC) #3

http://codereview.chromium.org/669051/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/669051/diff/1/2#newcode4961
src/objects.cc:4961: IteratePointers(v, kNameOffset,
kThisPropertyAssignmentsOffset + kPointerSize);
On 2010/03/04 09:47:15, Mads Ager wrote:
> Line 1 char too long?

Done.

http://codereview.chromium.org/669051/diff/1/3
File src/objects.h (right):

http://codereview.chromium.org/669051/diff/1/3#newcode3297
src/objects.h:3297: static const int kLengthOffset =
kThisPropertyAssignmentsOffset + kPointerSize;
Line too long: Done.

Expand Messages | Collapse Messages

Issue 669051: - Rearrange fields in SharedFunctionInfo. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages