Issue 669040: Fix RSA verification test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669040: Fix RSA verification test. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Fix RSA verification test. I previously refactored some of the signature generation code to directly use the OpenSSL library instead of invoking the "openssl" command line utility. The signature_digest command line utility got lost in the process. This restores the utility which in turn fixes the RSA verification test.

Patch Set 1 #

Patch Set 2 : "" #

Total comments: 3

Patch Set 3 : "" #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -7 lines)			Patch
M	src/platform/vboot_reference/tests/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/run_rsa_tests.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/utils/Makefile	View		3 chunks	+8 lines, -4 lines	0 comments	Download
A	src/platform/vboot_reference/utils/signature_digest_utility.c	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 9 months ago (2010-03-04 06:19:31 UTC) #2

LGTM, see nits

http://codereview.chromium.org/669040/diff/1002/1006
File src/platform/vboot_reference/utils/signature_digest_utility.c (right):

http://codereview.chromium.org/669040/diff/1002/1006#newcode5
src/platform/vboot_reference/utils/signature_digest_utility.c:5: * Utility that
outputs the cryptographic digest of a the contents of a
s/a the/the/

http://codereview.chromium.org/669040/diff/1002/1006#newcode6
src/platform/vboot_reference/utils/signature_digest_utility.c:6: * file in a
format that directly be used to generate PKCS#1 v1.5 signatures
/that directly be/that can be directly/

http://codereview.chromium.org/669040/diff/1002/1006#newcode27
src/platform/vboot_reference/utils/signature_digest_utility.c:27: if (argc !=3)
{
space before 3

Expand Messages | Collapse Messages