Vboot Reference: Kernel Boot signing utility.

Vboot Reference: Kernel Boot signing utility.

Fixes a unallocated memory bug in ReadKernelImage(). Some renaming of variables for consistency.

[sosa, 2010-03-04 01:02:25]

A comment and some nits for you.

Try running lint on kernel_utility.cc
http://codereview.chromium.org/lint_patch/issue669014_1007_13

Most notably you have some spaces missing after "if's" and since it's C++ use
reinterpret_cast<type**>() vs. (type**)

http://codereview.chromium.org/669014/diff/1007/13
File src/platform/vboot_reference/utils/kernel_utility.cc (right):

http://codereview.chromium.org/669014/diff/1007/13#newcode113
src/platform/vboot_reference/utils/kernel_utility.cc:113: switch(option_index) {
switch (

http://codereview.chromium.org/669014/diff/1007/13#newcode128
src/platform/vboot_reference/utils/kernel_utility.cc:128:
firmware_sign_algorithm_ = strtol(optarg, (char**) NULL, 10);
in C++ use reinterpret_cast<char**>(NULL)  ... also for other  casts too

http://codereview.chromium.org/669014/diff/1007/13#newcode220
src/platform/vboot_reference/utils/kernel_utility.cc:220:
sizeof(image_->header_checksum));
I've seen you do this calculation a few times.  You might wanna consider
functioning it out.

http://codereview.chromium.org/669014/diff/1007/13#newcode274
src/platform/vboot_reference/utils/kernel_utility.cc:274: if(!(error =
VerifyKernelImage(firmware_key_pub_, image_, 0)))
if (

[gauravsh, 2010-03-04 01:38:59]

I made a parallel set of changes to firmware_utility too since it's similar to
kernel_utility.

The no full pathnames for the #includes are here to stay since it's a standalone
package.

http://codereview.chromium.org/669014/diff/1007/13
File src/platform/vboot_reference/utils/kernel_utility.cc (right):

http://codereview.chromium.org/669014/diff/1007/13#newcode113
src/platform/vboot_reference/utils/kernel_utility.cc:113: switch(option_index) {
On 2010/03/04 01:02:25, sosa wrote:
> switch (

Done.

http://codereview.chromium.org/669014/diff/1007/13#newcode128
src/platform/vboot_reference/utils/kernel_utility.cc:128:
firmware_sign_algorithm_ = strtol(optarg, (char**) NULL, 10);
On 2010/03/04 01:02:25, sosa wrote:
> in C++ use reinterpret_cast<char**>(NULL)  ... also for other  casts too
Done.

http://codereview.chromium.org/669014/diff/1007/13#newcode220
src/platform/vboot_reference/utils/kernel_utility.cc:220:
sizeof(image_->header_checksum));
On 2010/03/04 01:02:25, sosa wrote:
> I've seen you do this calculation a few times.  You might wanna consider
> functioning it out.

As it turns out, i already had a function that does that. Fixed.

http://codereview.chromium.org/669014/diff/1007/13#newcode274
src/platform/vboot_reference/utils/kernel_utility.cc:274: if(!(error =
VerifyKernelImage(firmware_key_pub_, image_, 0)))
On 2010/03/04 01:02:25, sosa wrote:
> if (

Done.

[sosa, 2010-03-04 01:50:31]

l-g-t-m

http://codereview.chromium.org/669014/diff/1007/13
File src/platform/vboot_reference/utils/kernel_utility.cc (right):

http://codereview.chromium.org/669014/diff/1007/13#newcode220
src/platform/vboot_reference/utils/kernel_utility.cc:220:
sizeof(image_->header_checksum));
I thought so!  I looked for it for a bit but sadly my searching skillz are
lacking

On 2010/03/04 01:38:59, gauravsh wrote:
> On 2010/03/04 01:02:25, sosa wrote:
> > I've seen you do this calculation a few times.  You might wanna consider
> > functioning it out.
> 
> As it turns out, i already had a function that does that. Fixed. 
>