Switch half of PRESUBMIT.py to RunUnitTestsInDirectory()

PRESUBMIT.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for depot tools.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into depot_tools.
 """
 
-UNIT_TESTS = [
-  'tests.fix_encoding_test',
-  'tests.gcl_unittest',
-  'tests.gclient_scm_test',
-  'tests.gclient_smoketest',
-  'tests.gclient_utils_test',
-  'tests.owners_unittest',
-  'tests.presubmit_unittest',
-  'tests.scm_unittest',
-  'tests.trychange_unittest',
-  'tests.watchlists_unittest',
-]
-
 
 def CommonChecks(input_api, output_api):
-  output = []
-  # Verify that LocalPath() is local, e.g.:
-  #   os.path.join(PresubmitLocalPath(), LocalPath()) == AbsoluteLocalPath()
-  for i in input_api.AffectedFiles():
-    if (input_api.os_path.join(input_api.PresubmitLocalPath(), i.LocalPath()) !=
-        i.AbsoluteLocalPath()):
-      output.append(output_api.PresubmitError('Path inconsistency'))
-      # Return right away because it needs to be fixed first.
-      return output
+  results = []
 
-  output.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
-
-  output.extend(input_api.canned_checks.RunPythonUnitTests(
+  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
+  black_list = list(input_api.DEFAULT_BLACK_LIST) + [
+      r'^cpplint\.py$',
+      r'^tests[\/\\]\w+?[\/\\].+']
+  results.extend(input_api.canned_checks.RunPylint(
       input_api,
       output_api,
-      UNIT_TESTS))
+      white_list=[r'.*\.py$', r'^git-try$'],
+      black_list=black_list))
 
-  white_list = [r'.*\.py$', r'^git-try$']
-  black_list = list(input_api.DEFAULT_BLACK_LIST) + [
-      r'^cpplint\.py$',
-      r'^tests[\/\\]\w+?[\/\\].+',
-      ]
-  output.extend(input_api.canned_checks.RunPylint(
+  # TODO(maruel): Make sure at least one file is modified first.
+  # TODO(maruel): If only tests are modified, only run them.
+  verbose = False
+  results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
       input_api,
       output_api,
-      white_list=white_list,
-      black_list=black_list))
-  output.extend(RunGitClTests(input_api, output_api))
-  return output
+      'tests',
+      whitelist=[r'.*test\.py$'],
+      verbose=verbose))
+  results.extend(RunGitClTests(input_api, output_api))
+  return results
 
 
 def RunGitClTests(input_api, output_api):
   """Run all the shells scripts in the directory test.
   """
   # Not exposed from InputApi.
   from os import listdir
 
   # First loads a local Rietveld instance.
   import sys
@@ skipping 47 matching lines @@
   return CommonChecks(input_api, output_api)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   output = []
   output.extend(CommonChecks(input_api, output_api))
   output.extend(input_api.canned_checks.CheckDoNotSubmit(
       input_api,
       output_api))
   return output