Add more python 2.5 compatibility.

Add more python 2.5 compatibility.

Makes all the tests runnable on python 2.5.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80068

[Dirk Pranke, 2011-03-31 19:07:44]

I don't think this is a good change to make. I don't think the tests should
require 2.5 to be installed, and I think there should be other ways to ensure
that they do pass under 2.5 (e.g., the presubmit checks could run them under
both 2.6 and 2.5 if they are both installed, or favor 2.5 but use 2.6 if 2.5
isn't installed).

http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py
File tests/owners_unittest.py (right):

http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py#newcode12
tests/owners_unittest.py:12: sys.path.insert(0,
os.path.dirname(os.path.dirname(__file__)))
Why is this needed?

[M-A Ruel, 2011-03-31 19:14:47]

On 2011/03/31 19:07:44, Dirk Pranke wrote:
> I don't think this is a good change to make. I don't think the tests should
> require 2.5 to be installed, and I think there should be other ways to ensure
> that they do pass under 2.5 (e.g., the presubmit checks could run them under
> both 2.6 and 2.5 if they are both installed, or favor 2.5 but use 2.6 if 2.5
> isn't installed).

How would you do that?

http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py
File tests/owners_unittest.py (right):

http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py#newcode12
tests/owners_unittest.py:12: sys.path.insert(0,
os.path.dirname(os.path.dirname(__file__)))
On 2011/03/31 19:07:44, Dirk Pranke wrote:
> Why is this needed?

It's not guaranteed that 'depot_tools' will be in the path.

[Dirk Pranke, 2011-03-31 19:21:18]

On Thu, Mar 31, 2011 at 12:14 PM,  <maruel@chromium.org> wrote:
> On 2011/03/31 19:07:44, Dirk Pranke wrote:
>>
>> I don't think this is a good change to make. I don't think the tests
>> should
>> require 2.5 to be installed, and I think there should be other ways to
>> ensure
>> that they do pass under 2.5 (e.g., the presubmit checks could run them
>> under
>> both 2.6 and 2.5 if they are both installed, or favor 2.5 but use 2.6 if
>> 2.5
>> isn't installed).
>
> How would you do that?
>
fork off 'python2.5 --version' and see if it complete successfully or
not. Then use that instead of sys.executable.

-- Dirk

>
> http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py
> File tests/owners_unittest.py (right):
>
>
http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py#newcode12
> tests/owners_unittest.py:12: sys.path.insert(0,
> os.path.dirname(os.path.dirname(__file__)))
> On 2011/03/31 19:07:44, Dirk Pranke wrote:
>>
>> Why is this needed?
>
> It's not guaranteed that 'depot_tools' will be in the path.
>

Maybe we should fix that instead of hand-hacking sys.path in every file?

-- Dirk

[M-A Ruel, 2011-03-31 19:23:22]

Le 31 mars 2011 15:21, Dirk Pranke <dpranke@chromium.org> a écrit :

> On Thu, Mar 31, 2011 at 12:14 PM,  <maruel@chromium.org> wrote:
> > On 2011/03/31 19:07:44, Dirk Pranke wrote:
> >>
> >> I don't think this is a good change to make. I don't think the tests
> >> should
> >> require 2.5 to be installed, and I think there should be other ways to
> >> ensure
> >> that they do pass under 2.5 (e.g., the presubmit checks could run them
> >> under
> >> both 2.6 and 2.5 if they are both installed, or favor 2.5 but use 2.6 if
> >> 2.5
> >> isn't installed).
> >
> > How would you do that?
> >
> fork off 'python2.5 --version' and see if it complete successfully or
> not. Then use that instead of sys.executable.
>
> -- Dirk
>
> >
> > http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py
> > File tests/owners_unittest.py (right):
> >
> >
>
http://codereview.chromium.org/6690034/diff/1/tests/owners_unittest.py#newcode12
> > tests/owners_unittest.py:12: sys.path.insert(0,
> > os.path.dirname(os.path.dirname(__file__)))
> > On 2011/03/31 19:07:44, Dirk Pranke wrote:
> >>
> >> Why is this needed?
> >
> > It's not guaranteed that 'depot_tools' will be in the path.
> >
>
> Maybe we should fix that instead of hand-hacking sys.path in every file?
>

I prefer the tests to be runnable directly at the shell both with
./tests/name_test.py or ./name_test.py.

That's the only way to fix that.

I'll take a look at python2.5 live check.

[M-A Ruel, 2011-03-31 20:20:16]

I'll make the dynamic switching in another change.

[Dirk Pranke, 2011-03-31 20:33:01]

LGTM with the one nit.

http://codereview.chromium.org/6690034/diff/3002/tests/owners_unittest.py
File tests/owners_unittest.py (right):

http://codereview.chromium.org/6690034/diff/3002/tests/owners_unittest.py#new...
tests/owners_unittest.py:12: sys.path.insert(0,
os.path.dirname(os.path.dirname(__file__)))
I'm still not fond of this. Can you add a TODO somewhere to make this
unnecessary?