Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/code-stubs.h

Issue 6690014: Remove unused StringCharCodeAt stub. (Closed)
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 namespace v8 { 33 namespace v8 {
34 namespace internal { 34 namespace internal {
35 35
36 // List of code stubs used on all platforms. The order in this list is important 36 // List of code stubs used on all platforms. The order in this list is important
37 // as only the stubs up to and including Instanceof allows nested stub calls. 37 // as only the stubs up to and including Instanceof allows nested stub calls.
38 #define CODE_STUB_LIST_ALL_PLATFORMS(V) \ 38 #define CODE_STUB_LIST_ALL_PLATFORMS(V) \
39 V(CallFunction) \ 39 V(CallFunction) \
40 V(GenericBinaryOp) \ 40 V(GenericBinaryOp) \
41 V(TypeRecordingBinaryOp) \ 41 V(TypeRecordingBinaryOp) \
42 V(StringAdd) \ 42 V(StringAdd) \
43 V(StringCharAt) \
44 V(SubString) \ 43 V(SubString) \
45 V(StringCompare) \ 44 V(StringCompare) \
46 V(SmiOp) \ 45 V(SmiOp) \
47 V(Compare) \ 46 V(Compare) \
48 V(CompareIC) \ 47 V(CompareIC) \
49 V(MathPow) \ 48 V(MathPow) \
50 V(TranscendentalCache) \ 49 V(TranscendentalCache) \
51 V(Instanceof) \ 50 V(Instanceof) \
52 V(ConvertToDouble) \ 51 V(ConvertToDouble) \
53 V(WriteInt32ToHeapNumber) \ 52 V(WriteInt32ToHeapNumber) \
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 virtual void Generate(MacroAssembler* masm); 430 virtual void Generate(MacroAssembler* masm);
432 431
433 private: 432 private:
434 virtual CodeStub::Major MajorKey() { return MathPow; } 433 virtual CodeStub::Major MajorKey() { return MathPow; }
435 virtual int MinorKey() { return 0; } 434 virtual int MinorKey() { return 0; }
436 435
437 const char* GetName() { return "MathPowStub"; } 436 const char* GetName() { return "MathPowStub"; }
438 }; 437 };
439 438
440 439
441 class StringCharAtStub: public CodeStub {
442 public:
443 StringCharAtStub() {}
444
445 private:
446 Major MajorKey() { return StringCharAt; }
447 int MinorKey() { return 0; }
448
449 void Generate(MacroAssembler* masm);
450 };
451
452
453 class ICCompareStub: public CodeStub { 440 class ICCompareStub: public CodeStub {
454 public: 441 public:
455 ICCompareStub(Token::Value op, CompareIC::State state) 442 ICCompareStub(Token::Value op, CompareIC::State state)
456 : op_(op), state_(state) { 443 : op_(op), state_(state) {
457 ASSERT(Token::IsCompareOp(op)); 444 ASSERT(Token::IsCompareOp(op));
458 } 445 }
459 446
460 virtual void Generate(MacroAssembler* masm); 447 virtual void Generate(MacroAssembler* masm);
461 448
462 private: 449 private:
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
947 private: 934 private:
948 MacroAssembler* masm_; 935 MacroAssembler* masm_;
949 bool previous_allow_; 936 bool previous_allow_;
950 937
951 DISALLOW_COPY_AND_ASSIGN(AllowStubCallsScope); 938 DISALLOW_COPY_AND_ASSIGN(AllowStubCallsScope);
952 }; 939 };
953 940
954 } } // namespace v8::internal 941 } } // namespace v8::internal
955 942
956 #endif // V8_CODE_STUBS_H_ 943 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698