Add a route backwards from the DUT to the test host

Add a route backwards from the DUT to the test host

This is useful during VPN tests where the default route gets set.

BUG=chromium-os:13757
TEST=Manual: Inspected "ip" commands from debug log.  Thutt: Please
verify

Change-Id: Ib3c86243a6b13c95706b58549049b00df633c348

R=thutt@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=98d75b6

[Paul Stewart, 2011-04-01 21:35:03]

PTAL -- added error cleanup

[thutt, 2011-04-01 21:43:06]

Other than my piddling comments, and the fact that I'm not a Python expert,
LGTM.

http://codereview.chromium.org/6689026/diff/1/server/site_wifitest.py
File server/site_wifitest.py (right):

http://codereview.chromium.org/6689026/diff/1/server/site_wifitest.py#newcode...
server/site_wifitest.py:1235: # Set up a host route on the DUT so that the VPN
doesn't prevent us
Can you make this comment more clear?  It's rather convoluted at written.

http://codereview.chromium.org/6689026/diff/1/server/site_wifitest.py#newcode...
server/site_wifitest.py:1236: # from having IP traffic from it return to us
This comment too.
In my implementation, I split the if/elif starting at line 1239 into an if/if.  

I put the route addition between lines 1240 and 1240.  It's a negligible amount
of time, but at least you won't end up creating the route for error cases.

Conversely, the route is removed only if there is an actual VPN kind in
vpn_client_kill.

Feel free to ignore.

[Paul Stewart, 2011-04-01 21:52:45]

PTAL

http://codereview.chromium.org/6689026/diff/1/server/site_wifitest.py
File server/site_wifitest.py (right):

http://codereview.chromium.org/6689026/diff/1/server/site_wifitest.py#newcode...
server/site_wifitest.py:1236: # from having IP traffic from it return to us
On 2011/04/01 21:43:06, thutt wrote:
> This comment too.
> In my implementation, I split the if/elif starting at line 1239 into an if/if.
 
> 
> I put the route addition between lines 1240 and 1240.  It's a negligible
amount
> of time, but at least you won't end up creating the route for error cases.
> 
> Conversely, the route is removed only if there is an actual VPN kind in
> vpn_client_kill.
> 
> Feel free to ignore.

Feel free to move it where you'd like, and change the comment as well.  This is
just a suggestion, and I understand you're still actively working on this.

[thutt, 2011-04-01 22:01:56]

LGTM.
Thanks.

http://codereview.chromium.org/6689026/diff/5001/server/site_wifitest.py
File server/site_wifitest.py (right):

http://codereview.chromium.org/6689026/diff/5001/server/site_wifitest.py#newc...
server/site_wifitest.py:1237: # the default route) to change.  Set up a host
route backwards so
Thanks, that looks great.