Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 6688068: Change cctests to use variant flags as part of the name for the serilization file. (Closed)

Created:
9 years, 9 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Change cctests to use variant flags as part of the name for the serilization file. Because we run all tests three times with different variant flags (to test crankshaft) we might end up in a situation where we try to write to the same serilization file from two different threads simultaneously. The patch concats the variant flags at the end of the serialization file name. Committed: http://code.google.com/p/v8/source/detail?r=7285

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M test/benchmarks/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/testcfg.py View 4 chunks +5 lines, -3 lines 0 comments Download
M test/es5conform/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/message/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/mozilla/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/sputnik/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 9 months ago (2011-03-21 11:33:31 UTC) #1
Erik Corry
9 years, 9 months ago (2011-03-21 12:44:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698