Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: base/mach_ipc_mac.mm

Issue 6688056: Updating DCHECK() to DCHECK_GE() in base/ dir (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Moving definition of kEmptyMessageSize into .mm file Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mach_ipc_mac.mm
diff --git a/base/mach_ipc_mac.mm b/base/mach_ipc_mac.mm
index a0bfdc891f74c0437f6341cb07dea01baba7b942..7a4bffb0945a4bf0dde2f3ecf2d4ff385556928e 100644
--- a/base/mach_ipc_mac.mm
+++ b/base/mach_ipc_mac.mm
@@ -49,8 +49,13 @@ MachMessage::MachMessage(void *storage, size_t storage_length)
: storage_(static_cast<MachMessageData*>(storage)),
storage_length_bytes_(storage_length),
own_storage_(false) {
+ // The size of an empty message with no data.
Peter Kasting 2011/03/26 19:11:47 Nit: Remove comment (already commented in header).
KushalP 2011/03/26 20:23:14 Done.
+ kEmptyMessageSize = sizeof(mach_msg_header_t) +
Peter Kasting 2011/03/26 19:11:47 You should instead place this below "namespace bas
KushalP 2011/03/26 20:23:14 Done.
+ sizeof(mach_msg_body_t) +
+ sizeof(MessageDataPacket);
+
DCHECK(storage);
- DCHECK(storage_length >= kEmptyMessageSize);
+ DCHECK_GE(storage_length, kEmptyMessageSize);
}
//==============================================================================
« base/mach_ipc_mac.h ('K') | « base/mach_ipc_mac.h ('k') | base/message_pump_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698