Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: base/mach_ipc_mac.h

Issue 6688056: Updating DCHECK() to DCHECK_GE() in base/ dir (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Moving constant and removing public marker Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/mach_ipc_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mach_ipc_mac.h
diff --git a/base/mach_ipc_mac.h b/base/mach_ipc_mac.h
index d506a00c89d657e0c2262d9a8de43bc85dfcc9ca..d9ac548a5db5218fab3b09eabc761d3d6c0fd8ea 100644
--- a/base/mach_ipc_mac.h
+++ b/base/mach_ipc_mac.h
@@ -178,6 +178,8 @@ class MachMessage {
// Sets raw data for the message (returns false if not enough space)
bool SetData(const void* data, int32_t data_length);
+ static const size_t kEmptyMessageSize;
Peter Kasting 2011/03/27 19:22:59 Nit: This actually goes at the very top, above the
KushalP 2011/03/27 20:18:28 Done.
+
protected:
// Consider this an abstract base class - must create an actual instance
// of MachReceiveMessage or MachSendMessage
@@ -209,7 +211,6 @@ class MachMessage {
// of the Mach header.
size_t MaxSize() const { return storage_length_bytes_; }
- protected:
mach_msg_header_t *Head() { return &(storage_->head); }
private:
@@ -220,15 +221,6 @@ class MachMessage {
u_int8_t padding[1024];
};
- // kEmptyMessageSize needs to have the definition of MachMessageData before
- // it.
- public:
- // The size of an empty message with no data.
- static const size_t kEmptyMessageSize = sizeof(mach_msg_header_t) +
- sizeof(mach_msg_body_t) +
- sizeof(MessageDataPacket);
-
- private:
MachMessageData *storage_;
size_t storage_length_bytes_;
bool own_storage_; // Is storage owned by this object?
« no previous file with comments | « no previous file | base/mach_ipc_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698