Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2986)

Unified Diff: base/shared_memory_posix.cc

Issue 6688056: Updating DCHECK() to DCHECK_GE() in base/ dir (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Removed comments and added classname to static var Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/mach_ipc_mac.mm ('K') | « base/pickle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/shared_memory_posix.cc
diff --git a/base/shared_memory_posix.cc b/base/shared_memory_posix.cc
index 8dc9463cdc32356dd9d7089d0df94a94202037b7..5dc4c94ce05ef225908ef5cd843a26e7e5e9cfef 100644
--- a/base/shared_memory_posix.cc
+++ b/base/shared_memory_posix.cc
@@ -292,7 +292,7 @@ bool SharedMemory::FilePathForMemoryName(const std::string& mem_name,
}
void SharedMemory::LockOrUnlockCommon(int function) {
- DCHECK(mapped_file_ >= 0);
+ DCHECK_GE(mapped_file_, 0);
while (lockf(mapped_file_, function, 0) < 0) {
if (errno == EINTR) {
continue;
@@ -314,7 +314,7 @@ bool SharedMemory::ShareToProcessCommon(ProcessHandle process,
SharedMemoryHandle *new_handle,
bool close_self) {
const int new_fd = dup(mapped_file_);
- DCHECK(new_fd >= 0);
+ DCHECK_GE(new_fd, 0);
new_handle->fd = new_fd;
new_handle->auto_close = true;
« base/mach_ipc_mac.mm ('K') | « base/pickle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698