Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: base/mach_ipc_mac.mm

Issue 6688056: Updating DCHECK() to DCHECK_GE() in base/ dir (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Moving kEmptyMessageSize into namespace base Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mach_ipc_mac.mm
diff --git a/base/mach_ipc_mac.mm b/base/mach_ipc_mac.mm
index a0bfdc891f74c0437f6341cb07dea01baba7b942..fe534d37edd6d0cc85c3e167fa4035ae57a4bfe1 100644
--- a/base/mach_ipc_mac.mm
+++ b/base/mach_ipc_mac.mm
@@ -11,6 +11,11 @@
namespace base {
+// static
+const size_t kEmptyMessageSize = sizeof(mach_msg_header_t) +
Peter Kasting 2011/03/26 23:48:24 Sorry, I meant to say "MachSendMessage::kEmptyMess
KushalP 2011/03/27 00:25:15 Done.
+ sizeof(mach_msg_body_t) +
+ sizeof(MessageDataPacket);
+
//==============================================================================
MachSendMessage::MachSendMessage(int32_t message_id) : MachMessage() {
Initialize(message_id);
@@ -50,7 +55,7 @@ MachMessage::MachMessage(void *storage, size_t storage_length)
storage_length_bytes_(storage_length),
own_storage_(false) {
DCHECK(storage);
- DCHECK(storage_length >= kEmptyMessageSize);
+ DCHECK_GE(storage_length, kEmptyMessageSize);
}
//==============================================================================
« base/mach_ipc_mac.h ('K') | « base/mach_ipc_mac.h ('k') | base/message_pump_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698