Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: base/mach_ipc_mac.h

Issue 6688056: Updating DCHECK() to DCHECK_GE() in base/ dir (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Moving kEmptyMessageSize into namespace base Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/mach_ipc_mac.mm » ('j') | base/mach_ipc_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mach_ipc_mac.h
diff --git a/base/mach_ipc_mac.h b/base/mach_ipc_mac.h
index d506a00c89d657e0c2262d9a8de43bc85dfcc9ca..11b673544dd74cd743860f4c7b49848e9d94450f 100644
--- a/base/mach_ipc_mac.h
+++ b/base/mach_ipc_mac.h
@@ -223,10 +223,8 @@ class MachMessage {
// kEmptyMessageSize needs to have the definition of MachMessageData before
Peter Kasting 2011/03/26 23:48:24 Nit: This comment can now be removed and the const
KushalP 2011/03/27 00:25:15 Done.
Peter Kasting 2011/03/27 05:56:09 No, it's not. You removed the comment but didn't
KushalP 2011/03/27 10:17:17 Done.
// it.
public:
- // The size of an empty message with no data.
- static const size_t kEmptyMessageSize = sizeof(mach_msg_header_t) +
- sizeof(mach_msg_body_t) +
- sizeof(MessageDataPacket);
+ // The size of an empty message
Peter Kasting 2011/03/26 23:48:24 Nit: Heck, let's just remove this comment, it says
KushalP 2011/03/27 00:25:15 Done.
+ static const size_t kEmptyMessageSize;
private:
MachMessageData *storage_;
« no previous file with comments | « no previous file | base/mach_ipc_mac.mm » ('j') | base/mach_ipc_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698