Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 6688054: Move geolocation, desktop notification, and device orientation into their own message files. (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, jam, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move geolocation, desktop notification, and device orientation into their own message files.Also fix a regression from my earlier change to create a plugin through the embedder API. The fix is to not to create a plugin if the embedder returns NULL, and just have the default implementation create the plugin on its own.TBR=avi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78832

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -530 lines) Patch
chrome/browser/chromeos/notifications/desktop_notifications_unittest.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
chrome/browser/desktop_notification_handler.h View 2 chunks +7 lines, -9 lines 0 comments Download
chrome/browser/desktop_notification_handler.cc View 4 chunks +10 lines, -13 lines 0 comments Download
chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
chrome/browser/notifications/desktop_notification_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/notifications/desktop_notification_service.cc View 5 chunks +10 lines, -7 lines 0 comments Download
chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 13 chunks +14 lines, -15 lines 0 comments Download
chrome/browser/notifications/notification_object_proxy.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
chrome/common/common_param_traits.h View 2 chunks +0 lines, -9 lines 0 comments Download
chrome/common/common_param_traits.cc View 1 2 chunks +0 lines, -62 lines 0 comments Download
chrome/common/common_param_traits_unittest.cc View 1 2 2 chunks +0 lines, -40 lines 0 comments Download
chrome/common/render_messages.h View 7 chunks +0 lines, -97 lines 0 comments Download
chrome/common/render_messages_params.h View 5 chunks +0 lines, -60 lines 0 comments Download
chrome/common/render_messages_params.cc View 4 chunks +0 lines, -119 lines 0 comments Download
chrome/common/webkit_param_traits.h View 2 chunks +0 lines, -6 lines 0 comments Download
content/browser/device_orientation/message_filter.cc View 4 chunks +5 lines, -8 lines 0 comments Download
content/browser/geolocation/geolocation_dispatcher_host.cc View 3 chunks +6 lines, -8 lines 0 comments Download
content/browser/geolocation/geolocation_permission_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
content/browser/renderer_host/render_message_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
content/common/common_param_traits.h View 2 chunks +6 lines, -0 lines 0 comments Download
content/common/content_message_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
content/common/desktop_notification_messages.h View 1 chunk +80 lines, -0 lines 0 comments Download
content/common/device_orientation_messages.h View 1 chunk +36 lines, -0 lines 0 comments Download
content/common/geolocation_messages.h View 1 chunk +72 lines, -0 lines 0 comments Download
content/content_common.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
content/renderer/content_renderer_client.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
content/renderer/device_orientation_dispatcher.h View 2 chunks +5 lines, -3 lines 0 comments Download
content/renderer/device_orientation_dispatcher.cc View 5 chunks +6 lines, -8 lines 0 comments Download
content/renderer/geolocation_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
content/renderer/geolocation_dispatcher.cc View 6 chunks +10 lines, -13 lines 0 comments Download
content/renderer/notification_provider.cc View 6 chunks +15 lines, -16 lines 0 comments Download
content/renderer/render_view.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
ipc/ipc_message_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 9 months ago (2011-03-19 18:13:22 UTC) #1
Avi (use Gerrit)
9 years, 9 months ago (2011-03-19 19:36:48 UTC) #2
eyeballed, but I like where this is going. rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698