Issue 6688017: Apparently when I changed OptionallyDoPresubmitChecks() to return the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6688017: Apparently when I changed OptionallyDoPresubmitChecks() to return the (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Apparently when I changed OptionallyDoPresubmitChecks() to return the output object, I forgot to modify the commit command, and so now we're ignoring failures complete. That's not good :( Landing w/o review (but with unit tests!) to minimize damage. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78627

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -15 lines)			Patch
	M	gcl.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	tests/gcl_unittest.py	View		3 chunks	+117 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages