Normalize the top-level ui/ module.

Normalize the top-level ui/ module.

This CL creates four .gypi files that are included in /ui/ui.gyp. This allows
for a single unittest binary for all the submodules, rather than having
individual unittest binaries for each submodule.

To not break the buildbot, this creates a fake target that copies ui_unittests
to gfx_unittests as temporary scaffolding.

BUG=72317
TEST=gfx_unittests (really ui_unittests) passes

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78711

[Mark Mentovai, 2011-03-17 21:54:45]

LGTM

[Timur Iskhodzhanov, 2011-03-18 18:58:26]

I'm slightly worried that you've commited that without reviewing the master
change and restarting the master

[Robert Sesek, 2011-03-18 19:00:33]

On 2011/03/18 18:58:26, Timur Iskhodzhanov wrote:
> I'm slightly worried that you've commited that without reviewing the master
> change and restarting the master

Why? I abandoned putting ui_base on the waterfall because I decided having
multiple submodule unittest binaries is silly, so the change to chrome_tests.py
are fine. Replacing the gfx_unittests binary with ui_unitests was covered by the
tryjobs. I don't see how this affects buildbot.

[Timur Iskhodzhanov, 2011-03-18 19:15:11]

Ah, sorry, I haven't read these lines
>To not break the buildbot, this creates a fake target that copies ui_unittests
to gfx_unittests as temporary scaffolding.

On 2011/03/18 19:00:33, rsesek wrote:
> On 2011/03/18 18:58:26, Timur Iskhodzhanov wrote:
> > I'm slightly worried that you've commited that without reviewing the master
> > change and restarting the master
> 
> Why? I abandoned putting ui_base on the waterfall because I decided having
> multiple submodule unittest binaries is silly, so the change to
chrome_tests.py
> are fine. Replacing the gfx_unittests binary with ui_unitests was covered by
the
> tryjobs. I don't see how this affects buildbot.

[Ben Goodger (Google), 2011-03-18 20:26:28]

Can we leave ui/views out of this? I don't think it's even built right now
anywhere. It built on Windows last I tried but may not anymore. I am going
to remove it once I finish migrating the API to src/views.

-Ben

On Thu, Mar 17, 2011 at 2:51 PM, <rsesek@chromium.org> wrote:

> Reviewers: Mark Mentovai,
>
> Description:
> Normalize the top-level ui/ module.
>
> This CL creates four .gypi files that are included in /ui/ui.gyp. This
> allows
> for a single unittest binary for all the submodules, rather than having
> individual unittest binaries for each submodule.
>
> To not break the buildbot, this creates a fake target that copies
> ui_unittests
> to gfx_unittests as temporary scaffolding.
>
> BUG=72317
> TEST=gfx_unittests (really ui_unittests) passes
>
>
> Please review this at http://codereview.chromium.org/6688007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M app/app_base.gypi
>  M build/all.gyp
>  M chrome/chrome.gyp
>  M gpu/gpu.gyp
>  M remoting/remoting.gyp
>  M tools/heapcheck/chrome_tests.py
>  M tools/valgrind/chrome_tests.py
>  D ui/base/ui_base.gypi
>  D ui/gfx/gfx.gyp
>  M ui/ui.gyp
>  A ui/ui_base.gypi
>  A ui/ui_gfx.gypi
>  A ui/ui_unittests.gypi
>  A ui/ui_views.gypi
>  D ui/views/views.gyp
>  M webkit/support/webkit_support.gypi
>  M webkit/tools/test_shell/test_shell.gypi
>
>
>

[jeanluc1, 2011-03-18 20:53:50]

ui/ui_unittests.gypi includes a 'link_settings' element within 'msvs_settings'. 
This is not a valid element whithin msvs_settings.

Jean-Luc

On 2011/03/18 20:26:28, Ben Goodger wrote:
> Can we leave ui/views out of this? I don't think it's even built right now
> anywhere. It built on Windows last I tried but may not anymore. I am going
> to remove it once I finish migrating the API to src/views.
> 
> -Ben
> 
> On Thu, Mar 17, 2011 at 2:51 PM, <mailto:rsesek@chromium.org> wrote:
> 
> > Reviewers: Mark Mentovai,
> >
> > Description:
> > Normalize the top-level ui/ module.
> >
> > This CL creates four .gypi files that are included in /ui/ui.gyp. This
> > allows
> > for a single unittest binary for all the submodules, rather than having
> > individual unittest binaries for each submodule.
> >
> > To not break the buildbot, this creates a fake target that copies
> > ui_unittests
> > to gfx_unittests as temporary scaffolding.
> >
> > BUG=72317
> > TEST=gfx_unittests (really ui_unittests) passes
> >
> >
> > Please review this at http://codereview.chromium.org/6688007/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >  M app/app_base.gypi
> >  M build/all.gyp
> >  M chrome/chrome.gyp
> >  M gpu/gpu.gyp
> >  M remoting/remoting.gyp
> >  M tools/heapcheck/chrome_tests.py
> >  M tools/valgrind/chrome_tests.py
> >  D ui/base/ui_base.gypi
> >  D ui/gfx/gfx.gyp
> >  M ui/ui.gyp
> >  A ui/ui_base.gypi
> >  A ui/ui_gfx.gypi
> >  A ui/ui_unittests.gypi
> >  A ui/ui_views.gypi
> >  D ui/views/views.gyp
> >  M webkit/support/webkit_support.gypi
> >  M webkit/tools/test_shell/test_shell.gypi
> >
> >
> >

[Robert Sesek, 2011-03-21 19:11:27]

Ben: I've already committed this CL. There wasn't any side effect of including
views2, so you can just remove the gypi when you're ready to remove the code.

Jean-Luc: BradN submitted a fix for that. Sorry for the extra warning noise.

[Nico, 2011-07-04 21:14:46]

http://codereview.chromium.org/6688007/diff/32/ui/ui_gfx.gypi
File ui/ui_gfx.gypi (right):

http://codereview.chromium.org/6688007/diff/32/ui/ui_gfx.gypi#newcode24
ui/ui_gfx.gypi:24: 'message': 'TEMPORARY: Copying ui_unittests to
gfx_unittests',
Is there a bug for this, or any eta? I just lost a few minutes to this.

Is http://codereview.chromium.org/7212022/ something we would want? I wrote it
before finding this comment; now I'm not sure.