Issue 6688004: Perform a full self test before one-time initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6688004: Perform a full self test before one-time initialization. (Closed)

Created:
9 years, 9 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Perform a full self test before one-time initialization. Change-Id: I2f5232d5133c0725ec21f885a4632e980062be8f BUG=chrome-os-partner: 1826 TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=83c3714

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	firmware/lib/rollback_index.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Luigi Semenzato

The comment needs more reviewing than the code. Thanks!

9 years, 9 months ago (2011-03-17 17:18:55 UTC) #1

Luigi Semenzato

9 years, 9 months ago (2011-03-17 17:34:07 UTC) #3

Pushed!

On Thu, Mar 17, 2011 at 10:31 AM, <rspangler@chromium.org> wrote:

> LGTM -disaster
>
>
> http://codereview.chromium.org/6688004/
>