Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: media/filters/ffmpeg_demuxer_factory.cc

Issue 6686061: PipelineError is dead. Long live PipelineStatus! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: responses to 2nd CR Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/file_data_source.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop.h" 5 #include "base/message_loop.h"
6 #include "media/filters/ffmpeg_demuxer.h" 6 #include "media/filters/ffmpeg_demuxer.h"
7 #include "media/filters/ffmpeg_demuxer_factory.h" 7 #include "media/filters/ffmpeg_demuxer_factory.h"
8 8
9 namespace media { 9 namespace media {
10 10
(...skipping 13 matching lines...) Expand all
24 public: 24 public:
25 DemuxerCallbackAsPipelineStatusCallback( 25 DemuxerCallbackAsPipelineStatusCallback(
26 DemuxerFactory::BuildCallback* cb, 26 DemuxerFactory::BuildCallback* cb,
27 Demuxer* demuxer) 27 Demuxer* demuxer)
28 : cb_(cb), demuxer_(demuxer) { 28 : cb_(cb), demuxer_(demuxer) {
29 DCHECK(cb_.get() && demuxer_); 29 DCHECK(cb_.get() && demuxer_);
30 } 30 }
31 31
32 virtual ~DemuxerCallbackAsPipelineStatusCallback() {} 32 virtual ~DemuxerCallbackAsPipelineStatusCallback() {}
33 33
34 virtual void RunWithParams(const Tuple1<PipelineError>& params) { 34 virtual void RunWithParams(const Tuple1<PipelineStatus>& params) {
35 cb_->Run(params.a, demuxer_); 35 cb_->Run(params.a, demuxer_);
36 } 36 }
37 37
38 private: 38 private:
39 scoped_ptr<DemuxerFactory::BuildCallback> cb_; 39 scoped_ptr<DemuxerFactory::BuildCallback> cb_;
40 scoped_refptr<Demuxer> demuxer_; 40 scoped_refptr<Demuxer> demuxer_;
41 41
42 DISALLOW_IMPLICIT_CONSTRUCTORS(DemuxerCallbackAsPipelineStatusCallback); 42 DISALLOW_IMPLICIT_CONSTRUCTORS(DemuxerCallbackAsPipelineStatusCallback);
43 }; 43 };
44 44
45 // See comments on DemuxerCallbackAsPipelineStatusCallback above. 45 // See comments on DemuxerCallbackAsPipelineStatusCallback above.
46 class DemuxerCallbackAsDataSourceCallback : 46 class DemuxerCallbackAsDataSourceCallback :
47 public DataSourceFactory::BuildCallback { 47 public DataSourceFactory::BuildCallback {
48 public: 48 public:
49 DemuxerCallbackAsDataSourceCallback(DemuxerFactory::BuildCallback* cb, 49 DemuxerCallbackAsDataSourceCallback(DemuxerFactory::BuildCallback* cb,
50 MessageLoop* loop) 50 MessageLoop* loop)
51 : cb_(cb), loop_(loop) { 51 : cb_(cb), loop_(loop) {
52 DCHECK(cb_.get() && loop_); 52 DCHECK(cb_.get() && loop_);
53 } 53 }
54 54
55 virtual ~DemuxerCallbackAsDataSourceCallback() {} 55 virtual ~DemuxerCallbackAsDataSourceCallback() {}
56 56
57 virtual void RunWithParams(const Tuple2<PipelineError, DataSource*>& params) { 57 virtual void RunWithParams(
58 PipelineError status = params.a; 58 const Tuple2<PipelineStatus, DataSource*>& params) {
59 PipelineStatus status = params.a;
59 DataSource* data_source = params.b; 60 DataSource* data_source = params.b;
60 if (status != PIPELINE_OK) { 61 if (status != PIPELINE_OK) {
61 cb_->Run(status, static_cast<Demuxer*>(NULL)); 62 cb_->Run(status, static_cast<Demuxer*>(NULL));
62 return; 63 return;
63 } 64 }
64 DCHECK(data_source); 65 DCHECK(data_source);
65 scoped_refptr<FFmpegDemuxer> demuxer = new FFmpegDemuxer(loop_); 66 scoped_refptr<FFmpegDemuxer> demuxer = new FFmpegDemuxer(loop_);
66 demuxer->Initialize( 67 demuxer->Initialize(
67 data_source, 68 data_source,
68 new DemuxerCallbackAsPipelineStatusCallback(cb_.release(), demuxer)); 69 new DemuxerCallbackAsPipelineStatusCallback(cb_.release(), demuxer));
69 } 70 }
70 71
71 private: 72 private:
72 scoped_ptr<DemuxerFactory::BuildCallback> cb_; 73 scoped_ptr<DemuxerFactory::BuildCallback> cb_;
73 MessageLoop* loop_; 74 MessageLoop* loop_;
74 75
75 DISALLOW_IMPLICIT_CONSTRUCTORS(DemuxerCallbackAsDataSourceCallback); 76 DISALLOW_IMPLICIT_CONSTRUCTORS(DemuxerCallbackAsDataSourceCallback);
76 }; 77 };
77 78
78 void FFmpegDemuxerFactory::Build(const std::string& url, BuildCallback* cb) { 79 void FFmpegDemuxerFactory::Build(const std::string& url, BuildCallback* cb) {
79 data_source_factory_->Build( 80 data_source_factory_->Build(
80 url, new DemuxerCallbackAsDataSourceCallback(cb, loop_)); 81 url, new DemuxerCallbackAsDataSourceCallback(cb, loop_));
81 } 82 }
82 83
83 DemuxerFactory* FFmpegDemuxerFactory::Clone() const { 84 DemuxerFactory* FFmpegDemuxerFactory::Clone() const {
84 return new FFmpegDemuxerFactory(data_source_factory_->Clone(), loop_); 85 return new FFmpegDemuxerFactory(data_source_factory_->Clone(), loop_);
85 } 86 }
86 87
87 } // namespace media 88 } // namespace media
OLDNEW
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/file_data_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698